Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_dlm_lifecycle_policy: Implement support for Cross-Region Copy feature #12868

Merged
merged 4 commits into from
Nov 24, 2021
Merged

resource/aws_dlm_lifecycle_policy: Implement support for Cross-Region Copy feature #12868

merged 4 commits into from
Nov 24, 2021

Conversation

sysbart
Copy link
Contributor

@sysbart sysbart commented Apr 17, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #12204

Release note for CHANGELOG:

resource/aws_dlm_lifecycle_policy: Implement support for Cross-Region Copy feature

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSDlmLifecyclePolicy_Full'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDlmLifecyclePolicy_Full -timeout 120m
=== RUN   TestAccAWSDlmLifecyclePolicy_Full
=== PAUSE TestAccAWSDlmLifecyclePolicy_Full
=== CONT  TestAccAWSDlmLifecyclePolicy_Full
--- PASS: TestAccAWSDlmLifecyclePolicy_Full (68.75s)
PASS

@sysbart sysbart requested a review from a team April 17, 2020 02:02
@ghost ghost added size/L Managed by automation to categorize the size of a PR. needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/dlm Issues and PRs that pertain to the dlm service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 17, 2020
@sysbart sysbart changed the title resource/aws_dlm_lifecycle_policy: Implement support for Cross-Region Copy arguments resource/aws_dlm_lifecycle_policy: Implement support for Cross-Region Copy feature Apr 17, 2020
@rmlsun
Copy link

rmlsun commented Apr 29, 2020

Please consider merging this!

@bitle
Copy link

bitle commented Sep 15, 2020

I see a lot of value in this feature. What needs to be done to get this PR merged?

Base automatically changed from master to main January 23, 2021 00:57
@breathingdust breathingdust requested a review from a team as a code owner January 23, 2021 00:57
@ktasper
Copy link

ktasper commented Mar 16, 2021

Is there an update on this?

@breathingdust breathingdust added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Sep 21, 2021
@ayoubboulila
Copy link

ayoubboulila commented Sep 22, 2021 •
edited
Loading

Any Updates on this ? the pull request has been open for too long :(

@kakwa
Copy link

kakwa commented Oct 8, 2021

Just another user who would like this feature 👍

@zhelding
Copy link
Contributor

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

@anGie44 anGie44 self-assigned this Nov 23, 2021
@github-actions github-actions bot added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Nov 23, 2021
anGie44
anGie44 approved these changes Nov 24, 2021
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR @sysbart 🚀 ! Looked great overall, just a couple changes have been added to account for the provider codebase restructuring.

Output of acceptance tests:

--- PASS: TestAccDLMLifecyclePolicy_basic (26.33s)
--- PASS: TestAccDLMLifecyclePolicy_full (29.05s)
--- PASS: TestAccDLMLifecyclePolicy_tags (43.07s)
--- PASS: TestAccDLMLifecyclePolicy_crossRegionCopyRule (50.99s)

@anGie44 anGie44 added this to the v3.67.0 milestone Nov 24, 2021
@anGie44 anGie44 merged commit 697ab2e into hashicorp:main Nov 24, 2021
@github-actions
Copy link

github-actions bot commented Dec 1, 2021

This functionality has been released in v3.67.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@dpavlov-smartling dpavlov-smartling mentioned this pull request Apr 13, 2022
Open
@github-actions
Copy link

github-actions bot commented Jun 7, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees

@anGie44 anGie44

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/dlm Issues and PRs that pertain to the dlm service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.67.0
Development

Successfully merging this pull request may close these issues.

aws_dlm_lifecycle_policy - Implement support for "Cross Region copy"
9 participants
@sysbart @rmlsun @bitle @ktasper @ayoubboulila @kakwa @zhelding @anGie44 @breathingdust